Skip to content

fix: resolve ecosystem image URL using thirdweb storage #5120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2024
Merged

fix: resolve ecosystem image URL using thirdweb storage #5120

merged 1 commit into from
Oct 22, 2024

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Oct 22, 2024 •
edited by pr-codex bot
Loading

Problem solved

Fixes CNCT-2087

PR-Codex overview

This PR focuses on enhancing the Layout component in the wallet-ui application by improving how the ecosystem image is resolved, leveraging the resolveScheme function from the thirdweb/storage library.

Detailed summary

  • Added import for resolveScheme from thirdweb/storage.
  • Added import for client from ../../../lib/client.
  • Updated the src attribute of the img tag to use resolveScheme({ uri: ecosystem.imageUrl, client }) instead of directly using ecosystem.imageUrl.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 0:53am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 22, 2024 0:53am
thirdweb_playground ⬜️ Skipped (Inspect) Oct 22, 2024 0:53am
thirdweb-www ⬜️ Skipped (Inspect) Oct 22, 2024 0:53am

@vercel vercel bot temporarily deployed to Preview – docs-v2 October 22, 2024 00:49 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 22, 2024 00:49 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www October 22, 2024 00:49 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Oct 22, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 0e26a88

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 22, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@joaquim-verges joaquim-verges marked this pull request as ready for review October 22, 2024 00:49
@joaquim-verges Graphite App
Copy link
Member Author

joaquim-verges commented Oct 22, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joaquim-verges and the rest of your teammates on Graphite Graphite

@linear
Copy link

linear bot commented Oct 22, 2024

CNCT-2087 Investigate logo loading issue in Ecosystem wallet

@codecov
Copy link

codecov bot commented Oct 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.29%. Comparing base (50f98d7) to head (0e26a88).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5120   +/-   ##
=======================================
  Coverage   45.29%   45.29%           
=======================================
  Files        1059     1059           
  Lines       54754    54754           
  Branches     3959     3959           
=======================================
  Hits        24803    24803           
  Misses      29260    29260           
  Partials      691      691
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 50f98d7
packages 40.24% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 22, 2024 •
edited by joaquim-verges
Loading

Merge activity

@joaquim-verges
fix: resolve ecosystem image URL using thirdweb storage (#5120)
0e26a88 
## Problem solved

Fixes CNCT-2087

<!-- start pr-codex -->

---

## PR-Codex overview
This PR enhances the `Layout` component in the `layout.tsx` file by improving the way the ecosystem image URL is resolved using `resolveScheme`, ensuring proper handling of the image source.

### Detailed summary
- Added import for `resolveScheme` from `thirdweb/storage`.
- Added import for `client` from `../../../lib/client`.
- Updated the `src` attribute of the `<img>` tag to use `resolveScheme({ uri: ecosystem.imageUrl, client })` instead of directly using `ecosystem.imageUrl`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@joaquim-verges joaquim-verges force-pushed the fix_resolve_ecosystem_image_URL_using_thirdweb_storage branch from 95315d9 to 0e26a88 Compare October 22, 2024 00:52
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 22, 2024 00:52 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 22, 2024 00:52 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www October 22, 2024 00:52 Inactive
@graphite-app graphite-app bot merged commit 0e26a88 into main Oct 22, 2024
30 checks passed
@graphite-app graphite-app bot deleted the fix_resolve_ecosystem_image_URL_using_thirdweb_storage branch October 22, 2024 00:54
@vercel vercel bot temporarily deployed to Production – thirdweb-www October 22, 2024 00:54 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 October 22, 2024 00:54 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 22, 2024 00:54 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.81 KB (0%) 857 ms (0%) 4.5 s (+39.94% 🔺) 5.3 s
thirdweb (cjs) 102.66 KB (0%) 2.1 s (0%) 6.7 s (+11.36% 🔺) 8.8 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 202 ms (+15.12% 🔺) 299 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 55 ms (-32.78% 🔽) 65 ms
thirdweb/react (minimal + tree-shaking) 17.36 KB (0%) 348 ms (0%) 464 ms (-24.79% 🔽) 811 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls Awaiting requested review from jnsdls

@MananTank MananTank Awaiting requested review from MananTank

1 more reviewer

@gregfromstl gregfromstl gregfromstl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joaquim-verges @gregfromstl